Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] Implement closing Modal with title bar "X" button #14067

Open
TatianaKapos opened this issue Nov 1, 2024 · 0 comments · May be fixed by #14126
Open

[Modal] Implement closing Modal with title bar "X" button #14067

TatianaKapos opened this issue Nov 1, 2024 · 0 comments · May be fixed by #14126
Assignees
@TatianaKapos
Labels
Area: Fabric Support Facebook Fabric Area: Modal enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Milestone
Next

Comments

@TatianaKapos
Copy link
Contributor

Summary

Currently Modal has a title bar that contains an closing "X" button, however if the user clicks on that button, it messes up the visible property of Modal and won't reopen the Modal.

We should either remove the title bar or implement a way to close the modal with the "X" button.

Motivation

Implementation of Modal

Basic Example

No response

Open Questions

No response
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 1, 2024
@chrisglein chrisglein added this to the Next milestone Nov 4, 2024
@chrisglein chrisglein added Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs. Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) Area: Fabric Support Facebook Fabric Area: Modal New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) Area: Modal labels Nov 4, 2024
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 4, 2024
@TatianaKapos TatianaKapos linked a pull request Nov 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TatianaKapos TatianaKapos

Labels
Area: Fabric Support Facebook Fabric Area: Modal enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Projects
RNW New Architecture
Status: No status
Milestone
Next
Development

Successfully merging a pull request may close this issue.

[Fabric] Implement onDismiss for Modal and remove titlebar TatianaKapos/react-native-windows
2 participants
@chrisglein @TatianaKapos