[Fabric] Implement onDismiss for Modal and remove titlebar #14126
+379
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Area: Component Views
Area: Fabric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements onDismiss for Modal and removed the titlebar (Both Flyout/Popup/Modal don't have their own titlebar so by default Modal shouldn't have one either but it's easy to add it back in if needed! My guess is that the titlebar should be a windows-specific property).
This also means you no longer get the visual indicator that Modal needs to be dealt with before closing but Flyout/Popup also don't give a visual indicator.
Type of Change
Why
Resolves #13762
Resolves #14067
What
onDismiss doesn't work if you just implement the native-side because the Fabric-UI Manager destroys the Modal before the event can be fired. This PR enables the JavaScript portion of onDismiss for Modal that upstream implemented (see facebook/react-native#42601)
Screenshots
Testing
tested locally
Changelog
yes
Implements onDismiss for Modal and removes titlebar
Microsoft Reviewers: Open in CodeFlow