Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] Layout doesn't work with flex/padding styling #14070

Open
TatianaKapos opened this issue Nov 1, 2024 · 0 comments
Open

[Modal] Layout doesn't work with flex/padding styling #14070

TatianaKapos opened this issue Nov 1, 2024 · 0 comments
Assignees
@TatianaKapos
Labels
Area: Fabric Support Facebook Fabric Area: Layout Area: Modal bug New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Milestone
Next

Comments

@TatianaKapos
Copy link
Contributor

TatianaKapos commented Nov 1, 2024 •
edited
Loading

Problem Description

Modal works with a View that sets a height/width but gets funky with padding/flex styling. Need to figure out a better way to implement layout (this may involve splitting RNW Island into two different classes if layout diverges too much).

Currently Modal is getting the overflow of it's children and setting that to it's height/width. I'm not sure why add padding/flex to a child would change this overflow.

Steps To Reproduce

  1. Remove commented out lines in ModalPresentation.windows.js and ModalOnShow.windows.js
  2. Run Modal Example in playground-composition.cpp rntester
  3. Modal won't be the correct layout.

Expected Results

Modal has the correct layout
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 1, 2024
@chrisglein chrisglein added this to the Next milestone Nov 4, 2024
@chrisglein chrisglein added Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs. Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) Area: Fabric Support Facebook Fabric Area: Modal New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) Area: Modal labels Nov 4, 2024
@chrisglein chrisglein added Area: Layout and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TatianaKapos TatianaKapos

Labels
Area: Fabric Support Facebook Fabric Area: Layout Area: Modal bug New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Projects
RNW New Architecture
Status: No status
Milestone
Next
Development

No branches or pull requests
2 participants
@chrisglein @TatianaKapos