Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows codegen isn't run when running codegen for other platforms for new modules #14111

Open
jonthysell opened this issue Nov 13, 2024 · 1 comment
Labels
Area: Library Template Area: Turbo Modules enhancement Workstream: Module Support Module developers have the requisite tooling and clear path for adding windows support to modules.
Milestone

Comments

@jonthysell
Copy link
Contributor

Problem Description

The create-react-native-library base template includes the scripts to automatically run react-native codegen for ios/android as part of its build steps, but it doesn't run react-native codegen-windows.

We should figure out some way of ensuring developers also run windows codegen, so when they change their specs, windows stays in sync with the other platforms.

Steps To Reproduce

  1. Create a new library with the cpp-lib template
  2. Run yarn prepare

Expected Results

RNW codegen is also run

CLI version

15.0.0-alpha.2

Environment

info Fetching system and libraries information...
System:
  OS: Windows 11 10.0.26100
  CPU: (8) x64 Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz
  Memory: 6.43 GB / 15.84 GB
Binaries:
  Node:
    version: 18.18.0
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 3.6.1
    path: C:\Program Files (x86)\Yarn\bin\yarn.CMD
  npm:
    version: 9.8.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
    AllowAllTrustedApps: Enabled
    Versions:
      - 10.0.19041.0
      - 10.0.22000.0
      - 10.0.22621.0
IDEs:
  Android Studio: Not Found
  Visual Studio:
    - 17.11.35327.3 (Visual Studio Enterprise 2022)
Languages:
  Java: Not Found
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli":
    installed: 15.0.0-alpha.2
    wanted: 15.0.0-alpha.2
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.76.0
    wanted: 0.76.0
  react-native-windows:
    installed: 0.76.0
    wanted: 0.76.0
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

info React Native v0.76.1 is now available (your project is running on v0.76.0).
info Changelog: https://github.com/facebook/react-native/releases/tag/v0.76.1
info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.76.0&to=0.76.1
info For more info, check out "https://reactnative.dev/docs/upgrading?os=windows".

Community Modules

No response

Target Platform Version

10.0.22621

Target Device(s)

Desktop

Visual Studio Version

Visual Studio 2022

Build Configuration

Debug

Snack, code example, screenshot, or link to a repository

https://github.com/jonthysell/native-module-sample

@jonthysell jonthysell added the bug label Nov 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 13, 2024
@chrisglein chrisglein added Area: Turbo Modules Area: Library Template Workstream: Module Support Module developers have the requisite tooling and clear path for adding windows support to modules. labels Nov 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Nov 14, 2024
@chrisglein chrisglein added this to the Backlog milestone Nov 14, 2024
@chrisglein chrisglein removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric labels Nov 14, 2024
@chrisglein
Copy link
Member

chrisglein commented Nov 14, 2024

Design work needed here and likely upstream changes to accommodate this.
Tension between making this automatically versus making the manual steps simpler/clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Library Template Area: Turbo Modules enhancement Workstream: Module Support Module developers have the requisite tooling and clear path for adding windows support to modules.
Projects
None yet
Development

No branches or pull requests

2 participants