Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal RNW Codegen should output to FBReactNativeSpecJSI #14129

Open
acoates-ms opened this issue Nov 21, 2024 · 0 comments
Open

Internal RNW Codegen should output to FBReactNativeSpecJSI #14129

acoates-ms opened this issue Nov 21, 2024 · 0 comments
Assignees
@acoates-ms
Labels
Area: JSI Integration Follow-up
Milestone
Next

Comments

@acoates-ms
Copy link
Contributor

Internal headers such as the default turbo modules, expect the codegen'd files to be located at FBReactNativeSpecJSI/FBReactNativeSpecJSI.h

Currently our codegen outputs to codegen. This requires an additional header located at FBReactNativeSpecJSI/FBReactNativeSpecJSI.h that just #include's <codegen/rnwcoreJSI.h>

We should consider modifying the codegen logic to locate the generated files at a compatible location.
@acoates-ms acoates-ms self-assigned this Nov 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 21, 2024
@chrisglein chrisglein added Area: JSI Integration Follow-up and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Nov 21, 2024
@chrisglein chrisglein added this to the Next milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acoates-ms acoates-ms

Labels
Area: JSI Integration Follow-up
Projects
None yet
Milestone
Next
Development

No branches or pull requests
2 participants
@chrisglein @acoates-ms