Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TurboModuleImpl should override create instead of get to take advantage of caching #14132

Open
acoates-ms opened this issue Nov 21, 2024 · 0 comments
Open

TurboModuleImpl should override create instead of get to take advantage of caching #14132

acoates-ms opened this issue Nov 21, 2024 · 0 comments
Assignees
@acoates-ms
Labels
Area: Turbo Modules Integration Follow-up New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Milestone
Next

Comments

@acoates-ms
Copy link
Contributor

TurboModuleImpl currently implements TurboModule::get.

Instead it should override create. This would allow TurboModuleImpl to take advantage of the caching layer in TurboModule. And will be required in the future when Meta updates get to be final.
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Nov 21, 2024
@chrisglein chrisglein added this to the Next milestone Nov 21, 2024
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acoates-ms acoates-ms

Labels
Area: Turbo Modules Integration Follow-up New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
None yet
Milestone
Next
Development

No branches or pull requests
2 participants
@chrisglein @acoates-ms