Skip to content

Commit

Permalink
fix: update devcontainer dependency for codespace (#1037)
Browse files Browse the repository at this point in the history
# Description

One of the exist dependency doesn't work well for codespace env build,
have changed with necessary update
Related link:
https://github.com/devcontainers/features/tree/main/src/azure-cli

## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed
Before
<img width="1010" alt="before"
src="https://github.com/user-attachments/assets/826b714d-e420-41e0-93e5-70b0d1f090d3">
After
<img width="656" alt="after"
src="https://github.com/user-attachments/assets/0cf4226f-90e0-4dcf-8d31-3533cd859d48">

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
  • Loading branch information
xiaozhiche320 authored Nov 20, 2024
1 parent c64a7cf commit 4d00d2e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"ghcr.io/devcontainers/features/go:1": {},
"ghcr.io/devcontainers/features/kubectl-helm-minikube:1": {},
"ghcr.io/devcontainers-contrib/features/kind:1": {},
"ghcr.io/devcontainers-contrib/features/azure-cli:1": {}
"ghcr.io/devcontainers/features/azure-cli:1": {}
},
"postCreateCommand": "bash .devcontainer/installMoreTools.sh && kind create cluster",
"customizations": {
Expand Down

0 comments on commit 4d00d2e

Please sign in to comment.