Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node level metric for no VFPCounters #933

Open
anubhabMajumdar opened this issue Nov 4, 2024 · 0 comments
Open

Add node level metric for no VFPCounters #933

anubhabMajumdar opened this issue Nov 4, 2024 · 0 comments
Assignees
@ibezrukavyi @BeegiiK
Labels
area/metrics area/windows good first issue Good for newcomers help wanted Extra attention is needed lang/go The Go Programming Language priority/1 P1 type/enhancement New feature or request
Milestone
1.0

Comments

@anubhabMajumdar
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, if VFPCounters is zero, we log a error/warn message. Instead, this should be node level metric.
Ref: https://github.com/microsoft/retina/blame/ecdabdbf715fc8d2b180c7c6ebf858ad18d08207/pkg/plugin/windows/hnsstats/hnsstats_windows.go#L169

Describe the solution you'd like

A node level metric.
@anubhabMajumdar anubhabMajumdar added area/metrics area/windows good first issue Good for newcomers help wanted Extra attention is needed lang/go The Go Programming Language priority/1 P1 type/enhancement New feature or request labels Nov 4, 2024
@BeegiiK BeegiiK mentioned this issue Nov 6, 2024
Open
7 tasks
@anubhabMajumdar anubhabMajumdar added this to the 1.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibezrukavyi ibezrukavyi

@BeegiiK BeegiiK

Labels
area/metrics area/windows good first issue Good for newcomers help wanted Extra attention is needed lang/go The Go Programming Language priority/1 P1 type/enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@anubhabMajumdar @ibezrukavyi @BeegiiK