Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dep-check: support for devOnly in meta capabilities #1932

Open
AlekhyaYalla opened this issue Oct 14, 2022 · 1 comment
Open

Dep-check: support for devOnly in meta capabilities #1932

AlekhyaYalla opened this issue Oct 14, 2022 · 1 comment
Labels
enhancement New feature or request feature: align-deps This is related to align-deps

Comments

@AlekhyaYalla
Copy link

AlekhyaYalla commented Oct 14, 2022

Currently, dep-check will enforce capabilities with devOnly key in devDependencies section only. It would be good to have a similar feature for meta-capabilities as well so that all the capabilities part of that meta-capability would be enforced under devDependencies only.

Eg:

 "react-redux": {
    name: "react-redux",
    version: "^7.2.8",
  },
  "ts-node": {
    name: "ts-node",
    version: "^10.7.0",
    devOnly: true
  },
  "meta/common": {
    name: "#meta",
    capabilities: [
      "react-redux",
      "ts-node"
    ],
    devOnly: true
  }

currently with the above profile, when meta/common is used in package.json->rnx-kit->capabilities field, then ts-node will be in devDependencies and react-redux will be in devDependencies + peerDependencies section.

Ask is for, with the above profile, both ts-node and react-redux will be added under the devDependencies section only.

Thanks!

@ghost ghost added the needs triage 🔍 label Oct 14, 2022
@tido64 tido64 added enhancement New feature or request feature: align-deps This is related to align-deps and removed needs triage 🔍 labels Oct 14, 2022
@tido64
Copy link
Member

tido64 commented Oct 17, 2022

I think we can do this, but it won't be done until #1890 is done. And it will most likely only be available in 2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature: align-deps This is related to align-deps
Projects
None yet
Development

No branches or pull requests

2 participants