-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: #5908 conditionalize dependencies #6479
.Net: #5908 conditionalize dependencies #6479
Conversation
f557646
to
01621bc
Compare
maybe also |
01621bc
to
ca081c0
Compare
eed8bb5
to
7a5a192
Compare
7a5a192
to
5daca72
Compare
dotnet/src/SemanticKernel.Abstractions/SemanticKernel.Abstractions.csproj
Show resolved
Hide resolved
745389d
to
e70097c
Compare
e70097c
to
35a8875
Compare
9398ac6
to
b370870
Compare
b370870
to
1edecc6
Compare
@@ -18,10 +18,11 @@ | |||
</PropertyGroup> | |||
|
|||
<ItemGroup> | |||
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" /> | |||
<PackageReference Include="Microsoft.Bcl.HashCode" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in the netstandard2.0
item group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
U are right will make that additional cleanup tomorrow morning my time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markwallace-microsoft it appears that Microsoft.BCL.HashCode is not needed at all & Microsoft.Bcl.AsyncInterfaces is being imported as a transitive dependency. Not sure if the abstractions explicitly need this dependency.
9253869
to
2ab2a03
Compare
2ab2a03
to
efa5a91
Compare
@dmytrostruk is going to continue this work, tracking with #8109 . We want to make sure we have the correct test coverage before merging this. |
@dmytrostruk is going to continue this work, tracking with #8109., this PR will be updated as part of this task |
Motivation and Context
This reduces the dependency graph by making STJ only included on net standard
Description
This simply makes dependencies which are available as part of the framework conditional so that they are not being un-necessarily included
Contribution Checklist
Closes #5908