-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Add Mssql Server connector, using vector search with plain tables #6482
Conversation
dotnet/src/Connectors/Connectors.Memory.MssqlServer/ISqlServerClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.MssqlServer/SqlServerClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.MssqlServer/SqlServerMemoryEntry.cs
Outdated
Show resolved
Hide resolved
60f7b34
to
260f720
Compare
Since we also have a connector using the native vector functions (here: https://github.com/microsoft/semantic-kernel/tree/main/dotnet/src/Connectors/Connectors.Memory.SqlServer) can we call this connector That would help to bring clarity and have a clear differentiation between the one supporting native vectors functions and the one using a "classic" approach. |
@RogerBarreto and @yorek as discussed internally, I renamed the connector to "classic" to match the clarity objectives regarding native approach... Thank you! |
...rc/Connectors/Connectors.Memory.SqlServer.Classic/Connectors.Memory.SqlServer.Classic.csproj
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/Core/SqlServerClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/Core/SqlServerClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/Core/SqlServerClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/Core/SqlServerClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/Core/SqlServerClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/Core/SqlServerClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/SqlServerMemoryStore.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/SqlServerMemoryStore.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/SqlServerMemoryStore.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/Core/SqlServerClient.cs
Outdated
Show resolved
Hide resolved
4e9a9b7
to
b447d1c
Compare
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/Core/SqlServerClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/SqlServerConfig.cs
Outdated
Show resolved
Hide resolved
dotnet/src/IntegrationTests/Connectors/Memory/SqlServer/ClassicSqlServerMemoryStoreTests.cs
Outdated
Show resolved
Hide resolved
a58f57d
to
6754c48
Compare
@kbeaugrand Can you run |
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/SqlServerMemoryBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/SqlServerConfig.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.SqlServer.Classic/SqlServerMemoryStore.cs
Outdated
Show resolved
Hide resolved
yes done ! |
…emanticKernel.Connectors.SqlServer.Classic
@RogerBarreto @cincuranet @markwallace-microsoft just checking if we're ready to release this PR. Looking forward to blog about this |
I think we are (minus the failures from CI). |
@kbeaugrand Apologies for the delay in getting back to you. Can you resolve the merge conflict and run dotnet format. I'll do a second review early next week with the plan to get this merged soonest. |
@kbeaugrand we recently announced support for the new Microsoft.Extensions.VectorData.Abstractions. Our plan is to obsolete the old memory store abstractions so we're closing PR's that use those. If you are interested in updating to use the new Microsoft.Extensions.VectorData.Abstractions, we can consider this for additional the Semantic Kernel. |
Motivation and Context
Adding MSSQL Server connector.
Description
SQL server connector works when vector search capability is enabled in SQL server (In azure it works), but in on prem scenarios, vector search is not accessible.
This PR uses plain tables to provide vector search using SQL features.
Contribution Checklist