Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Add Mssql Server connector, using vector search with plain tables #6482

Closed
wants to merge 13 commits into from

Conversation

kbeaugrand
Copy link
Contributor

@kbeaugrand kbeaugrand commented Jun 2, 2024

Motivation and Context

Adding MSSQL Server connector.

Description

SQL server connector works when vector search capability is enabled in SQL server (In azure it works), but in on prem scenarios, vector search is not accessible.
This PR uses plain tables to provide vector search using SQL features.

Contribution Checklist

@kbeaugrand kbeaugrand requested a review from a team as a code owner June 2, 2024 08:22
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels Jun 2, 2024
@github-actions github-actions bot changed the title Add Mssql Server connector, using vector search with plain tables .Net: Add Mssql Server connector, using vector search with plain tables Jun 2, 2024
@kbeaugrand kbeaugrand force-pushed the main branch 2 times, most recently from 60f7b34 to 260f720 Compare June 4, 2024 21:29
@yorek
Copy link
Member

yorek commented Jun 4, 2024

Since we also have a connector using the native vector functions (here: https://github.com/microsoft/semantic-kernel/tree/main/dotnet/src/Connectors/Connectors.Memory.SqlServer) can we call this connector Microsoft.SemanticKernel.Connectors.SqlServer.Classic instead of Microsoft.SemanticKernel.Connectors.MssqlServer.

That would help to bring clarity and have a clear differentiation between the one supporting native vectors functions and the one using a "classic" approach.

@kbeaugrand
Copy link
Contributor Author

@RogerBarreto and @yorek as discussed internally, I renamed the connector to "classic" to match the clarity objectives regarding native approach...

Thank you!

@markwallace-microsoft
Copy link
Member

@kbeaugrand Can you run dotnet format and commit the resulting changes

@kbeaugrand
Copy link
Contributor Author

@kbeaugrand Can you run dotnet format and commit the resulting changes

yes done !

@yorek
Copy link
Member

yorek commented Aug 27, 2024

@RogerBarreto @cincuranet @markwallace-microsoft just checking if we're ready to release this PR. Looking forward to blog about this

@cincuranet
Copy link
Contributor

I think we are (minus the failures from CI).

@markwallace-microsoft markwallace-microsoft self-assigned this Sep 20, 2024
@markwallace-microsoft
Copy link
Member

@kbeaugrand Apologies for the delay in getting back to you. Can you resolve the merge conflict and run dotnet format. I'll do a second review early next week with the plan to get this merged soonest.

@markwallace-microsoft
Copy link
Member

@kbeaugrand we recently announced support for the new Microsoft.Extensions.VectorData.Abstractions. Our plan is to obsolete the old memory store abstractions so we're closing PR's that use those. If you are interested in updating to use the new Microsoft.Extensions.VectorData.Abstractions, we can consider this for additional the Semantic Kernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

6 participants