Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate target latent state using the right encoder #10

Open
antoine-galataud opened this issue Jun 29, 2023 · 1 comment
Open

Generate target latent state using the right encoder #10

antoine-galataud opened this issue Jun 29, 2023 · 1 comment

Comments

@antoine-galataud
Copy link

In the forward prediction objective and when observations vector is used, it looks like the wrong encoder is used.

next_state_embeddings = self.state_encoder(states).detach()

Instead it should be the momentum encoder self.target_state_encoder to correctly generate target latent state embeddings.

@ycsun2017
Copy link
Collaborator

@antoine-galataud Thank you for the comment! This is indeed a typo. But don't worry, since this line is under the "vector_obs" condition, it will not affect the current experiments with pixel obs. We apologize for the confusion and have removed the lines related to this unused condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants