You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It restricts the means for authentication to using the configuration-based approach only in two ways:
a) it doesn't expose an equivalent to the CloudAdapter constructor that accepts a custom BotFrameworkAuthentication instance.
b) it hardcodes usage of ConfigurationServiceClientCredentialFactory.
This makes it impossible to use Teams.AI when the underlying bot framework configuration is using federated credentials, which is currently pending a configuration-based implementation (see microsoft/botbuilder-dotnet#6838).
Solution
One or both of the following:
The bot framework implements the configuration-based approach for federated credentials (I've suggested an extension of this PR here).
The Teams.AI library allows passing a custom BotFrameworkAuthentication instance to TeamsAdapter.
Just the first approach will work as an immediate solution and may be the easier of the two, but the second approach seems like it should be supported in general to enable more flexibility around authentication.
Additional Context
Thanks in advance for considering!
The text was updated successfully, but these errors were encountered:
Scenario
Please look at this code:
https://github.com/microsoft/teams-ai/blob/main/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/Application/TeamsAdapter.cs#L48
It restricts the means for authentication to using the configuration-based approach only in two ways:
a) it doesn't expose an equivalent to the
CloudAdapter
constructor that accepts a customBotFrameworkAuthentication
instance.b) it hardcodes usage of
ConfigurationServiceClientCredentialFactory
.This makes it impossible to use Teams.AI when the underlying bot framework configuration is using federated credentials, which is currently pending a configuration-based implementation (see microsoft/botbuilder-dotnet#6838).
Solution
One or both of the following:
BotFrameworkAuthentication
instance toTeamsAdapter
.Just the first approach will work as an immediate solution and may be the easier of the two, but the second approach seems like it should be supported in general to enable more flexibility around authentication.
Additional Context
Thanks in advance for considering!
The text was updated successfully, but these errors were encountered: