Remove Monarch/Peasant & Make UI single-threaded #18215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
changed the title
microsoft-github-policy-service
bot
added
Issue-Bug
lhecker
force-pushed
the
dev/lhecker/dethronement
branch
from
b39c5a7
to
7853853
Compare
lhecker
commented
Nov 19, 2024
| @@ -170,7 +170,6 @@ namespace winrt::TerminalApp::implementation | |||
|
|
|||
| const auto canDragDrop = CanDragDrop(); | |||
|
|
|||
| _tabRow.PointerMoved({ get_weak(), &TerminalPage::_RestorePointerCursorHandler }); | |||
There was a problem hiding this comment.
Moved into TerminalControl as a different workaround is needed for this functionality.
| { | ||
| auto weakThis{ get_weak() }; | ||
| co_await wil::resume_foreground(Dispatcher()); |
There was a problem hiding this comment.
No multi-threading = No problem. (Suppress whitespace in the diff.)
DHowett
reviewed
Nov 19, 2024
| <CurrentXamlPackage Include="@(AppxPackageRegistration)" | ||
| Condition="'%(AppxPackageRegistration.Architecture)'=='$(Platform)' AND | ||
| $([System.String]::new('%(AppxPackageRegistration.Filename)').StartsWith('Microsoft.UI.Xaml'))" /> | ||
| <CurrentXamlPackage Include="@(AppxPackageRegistration)" Condition="'%(AppxPackageRegistration.Architecture)'=='$(Platform)' AND
 $([System.String]::new('%(AppxPackageRegistration.Filename)').StartsWith('Microsoft.UI.Xaml'))" /> |
DHowett
reviewed
Nov 19, 2024
|
DHowett
reviewed
Nov 19, 2024
| auto isCurrentlyDark = Theme::IsSystemInDarkTheme(); | ||
| if (isCurrentlyDark != _currentSystemThemeIsDark) | ||
| { | ||
| _currentSystemThemeIsDark = isCurrentlyDark; |
There was a problem hiding this comment.
📝 DH - Guessing this moved to the Message Window; confirm
microsoft-github-policy-service
bot
added
the
Area-Windowing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As before, a minor refactor:
it into and deduplicating its functionality with
WindowEmperor.a single instance), I wrote single-instance code with a NT mutex
and by yeeting data across processes with
WM_COPYDATA.way faster. The more I tried to solve them the deeper I had to dig,
because you can't just put a mutex around
CascadiaSettings.I then tried to seeif WinUI can run multiple windows on a single
thread and, as it turns out, it can.
So, I removed the multi- from the window threading.
So, to finish it up, I had to clean up the entire eventing system
around
WindowEmperor, cleaned up all the coroutines,and cleaned up all the callbacks.
Closes #16733
Closes #17799
Closes #18176
Closes #18191
TODO: Find other issues
Validation Steps Performed