Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AvoidExpectedExceptionAttributeAnalyzer doesn't handle attributes that derive from ExpectedExceptionBaseAttribute #4034

Closed
Youssef1313 opened this issue Nov 11, 2024 · 0 comments · Fixed by #4045
Closed

AvoidExpectedExceptionAttributeAnalyzer doesn't handle attributes that derive from ExpectedExceptionBaseAttribute #4034

Youssef1313 opened this issue Nov 11, 2024 · 0 comments · Fixed by #4045
Assignees
@Youssef1313
Labels
Area: Analyzers In-PR Type: Bug
Milestone
MSTest 3.7 / Plat...

Comments

@Youssef1313
Copy link
Member

Describe the bug

The analyzer specifically looks for ExpectedExceptionAttribute, while users could have their own custom ExpectedExceptionBaseAttribute derived class

Steps To Reproduce

Expected behavior

Actual behavior

Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
Area: Analyzers In-PR Type: Bug
Projects
None yet
Milestone
MSTest 3.7 / Platform 1.5
Development

Successfully merging a pull request may close this issue.

Respect custom ExpectedExceptionBase attribute implementations Youssef1313/testfx
2 participants
@Evangelink @Youssef1313