fix: Open the extension page on installation (#556)

Author: jdneo

package.nls.json

@@ -40,5 +40,5 @@
   "viewsWelcome.workbench.createNewJavaProject": "You can also [open a Java project folder](command:_java.project.open), or create a new Java project by clicking the button below.\n[Create Java Project](command:java.project.create)",
   "viewsWelcome.workbench.noJavaProject": "No Java projects found in the current workspace. You can [open a Java project folder](command:_java.project.open), or create a new Java project by clicking the button below.\n[Create Java Project](command:java.project.create)",
   "viewsWelcome.workbench.inLightWeightMode": "To view the projects, you can import the projects into workspace.\n[Import Projects](command:java.server.mode.switch?%5B%22Standard%22,true%5D)",
-  "viewsWelcome.workbench.installLanguageSupport": "The Java Projects explorer requires [Extension Pack for Java](command:extension.open?%5B%22vscjava.vscode-java-pack%22%5D) to provide full features.\n[Install](command:workbench.extensions.installExtension?%5B%22vscjava.vscode-java-pack%22%5D)"
+  "viewsWelcome.workbench.installLanguageSupport": "The Java Projects explorer requires [Extension Pack for Java](command:extension.open?%5B%22vscjava.vscode-java-pack%22%5D) to provide full features.\n[Install](command:java.project.installExtension?%5B%22vscjava.vscode-java-pack%22%5D)"
 }

package.nls.zh.json

@@ -40,5 +40,5 @@
   "viewsWelcome.workbench.createNewJavaProject": "您也可以[打开一个 Java 项目目录](command:_java.project.open)，或点击下方按钮创建一个新的 Java 项目。\n[创建 Java 项目](command:java.project.create)",
   "viewsWelcome.workbench.noJavaProject": "当前工作空间未发现 Java 项目，您可以[打开一个 Java 项目目录](command:_java.project.open)，或点击下方按钮创建一个新的 Java 项目。\n[创建 Java 项目](command:java.project.create)",
   "viewsWelcome.workbench.inLightWeightMode": "要浏览项目信息，你可以将项目导入到工作空间中。\n[导入项目](command:java.server.mode.switch?%5B%22Standard%22,true%5D)",
-  "viewsWelcome.workbench.installLanguageSupport": "Java 项目视图需要安装并激活 [Extension Pack for Java](command:extension.open?%5B%22vscjava.vscode-java-pack%22%5D) 以提供完整的功能。\n[安装](command:workbench.extensions.installExtension?%5B%22vscjava.vscode-java-pack%22%5D)"
+  "viewsWelcome.workbench.installLanguageSupport": "Java 项目视图需要安装并激活 [Extension Pack for Java](command:extension.open?%5B%22vscjava.vscode-java-pack%22%5D) 以提供完整的功能。\n[安装](command:java.project.installExtension?%5B%22vscjava.vscode-java-pack%22%5D)"
 }

src/commands.ts

@@ -84,6 +84,8 @@ export namespace Commands {
 
     export const JAVA_PROJECT_LIST_SOURCE_PATHS = "java.project.listSourcePaths";
 
+    export const INSTALL_EXTENSION = "java.project.installExtension";
+
     /**
      * Commands from Visual Studio Code
      */

src/controllers/projectController.ts

@@ -17,6 +17,13 @@ export class ProjectController implements Disposable {
         this.disposable = Disposable.from(
             instrumentOperationAsVsCodeCommand(Commands.JAVA_PROJECT_CREATE, () => this.createJavaProject()),
             instrumentOperationAsVsCodeCommand(Commands.JAVA_PROJECT_OPEN, () => this.openJavaProject()),
+            instrumentOperationAsVsCodeCommand(Commands.INSTALL_EXTENSION, (extensionId: string) => {
+                commands.executeCommand("workbench.extensions.installExtension", extensionId);
+                // So far there is no API to query the extension's state, so we open the extension's homepage
+                // here, where users can check the state: installing, disabled, installed, etc...
+                // See: https://github.com/microsoft/vscode/issues/14444
+                commands.executeCommand("extension.open", extensionId);
+            }),
         );
     }
 
@@ -101,11 +108,7 @@ async function ensureExtension(typeName: string, metaData: IProjectTypeMetadata)
 async function promptInstallExtension(projectType: string, metaData: IProjectTypeMetadata): Promise<void> {
     const choice: string | undefined = await window.showInformationMessage(`${metaData.extensionName} is required to create ${projectType} projects. Please re-run the command 'Java: Create Java Project...' after the extension is installed.`, "Install");
     if (choice === "Install") {
-        commands.executeCommand("workbench.extensions.installExtension", metaData.extensionId);
-        // So far there is no API to query the extension's state, so we open the extension's homepage
-        // here, where users can check the state: installing, disabled, installed, etc...
-        // See: https://github.com/microsoft/vscode/issues/14444
-        commands.executeCommand("extension.open", metaData.extensionId);
+        commands.executeCommand(Commands.INSTALL_EXTENSION, metaData.extensionId);
     }
 }