Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iJavaScript Exception in cell will cause timeout #8014

Closed
franz101 opened this issue Oct 23, 2021 · 5 comments
Closed

iJavaScript Exception in cell will cause timeout #8014

franz101 opened this issue Oct 23, 2021 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug language-any Area covering general issues geared to supporting any language (not just Python) notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) verified Verification succeeded
Milestone

Comments

@franz101
Copy link

Environment data

  • VS Code version: 1.61.2
  • Jupyter Extension version (available under the Extensions sidebar): v2021.9.1101343141
  • Python Extension version (available under the Extensions sidebar): v2021.10.1365161279
  • OS (Windows | Mac | Linux distro) and version: 11.6 (20G165) M1
  • Python and/or Anaconda version: mini-forge arm 3.9.6
  • Jupyter server running: Local

Expected behaviour

Running iJavaScript with jupyter lab works without errors... When I create a duplicate variable it will run the next cell if let it run.

Actual behaviour

Screenshot 2021-10-23 at 02 27 52

Steps to reproduce:

  1. Install iJavaScript
  2. Create an ipynb file
  3. Choose iJavaScript Kernel
  4. write invalid js and everything will crash
@franz101 franz101 added the bug Issue identified by VS Code Team member as probable bug label Oct 23, 2021
@DonJayamanne DonJayamanne added the notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) label Oct 25, 2021
@DonJayamanne
Copy link
Contributor

I can repro this on an M1.
May have something to do with the way we launch Jupyter (I can see that launching jupyter outside and running the same kernels work).

In the mean time you might want to take a look at https://marketplace.visualstudio.com/items?itemName=donjayamanne.typescript-notebook (this doesn't require such installations). Please create a with the the extension nnb, such as sample.nnb. Support for jupyter notebooks is coming soon.

@DonJayamanne
Copy link
Contributor

Notes for the team:

  • I believe the root cause is running externals without zeromq support.
  • May have something to do with the way we launch Jupyter (I can see that launching jupyter outside and running the same kernels work).

@greazer greazer added language-any Area covering general issues geared to supporting any language (not just Python) and removed needs-triage labels Oct 25, 2021
@franz101
Copy link
Author

franz101 commented Nov 6, 2021

You are a champ, will check out the extension you mentioned. Often the problem was that the some notebooks weren't using the local tsconfig

@DonJayamanne DonJayamanne added this to the March 2022 milestone Feb 28, 2022
@DonJayamanne DonJayamanne self-assigned this Feb 28, 2022
@DonJayamanne
Copy link
Contributor

I've tested this with our latest dev version of the extension and it works as expected.
I'm closing this issue as resolved. We're planning on releasing a new version this week.

Closing so as to get this validated.

@rchiodo rchiodo added the verified Verification succeeded label Mar 24, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Mar 24, 2022

/verified

image

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug language-any Area covering general issues geared to supporting any language (not just Python) notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants