Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile errors for tools extensions due to vscodeTypes.d.ts #120

Open
joyceerhl opened this issue Oct 22, 2024 · 1 comment
Open

Compile errors for tools extensions due to vscodeTypes.d.ts #120

joyceerhl opened this issue Oct 22, 2024 · 1 comment
Assignees
Labels

Comments

@joyceerhl
Copy link
Contributor

This library mirrors several VS Code types in https://github.com/microsoft/vscode-prompt-tsx/blob/3d2874137df8515e49476c55fb3f4f7bc8ba5469/src/base/vscodeTypes.d.ts, we should avoid this if possible and find a better solution because it is currently causing compile errors for tools extensions.

Filing on request from @jrieken

@connor4312
Copy link
Member

I think we'd remove the types there and have @types/vscode as an optionalDependency. Then instruct users to install it alongside prompt tsx, and possibly do it automatically for them if @vscode/dts is not already installed (like how esbuild automatically installs the optional dependency with the binary for the current platform)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants