New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove either `npm run compile` or `npm run build` #40

Open

hediet opened this issue May 28, 2024 · 0 comments

Member

hediet commented May 28, 2024 •

edited

Loading

It seems that npm run build is currently broken due to a runtime import of vscode:

CI avoids this issue by running npm run compile:

vscode-prompt-tsx/build/base.yml

Line 57 in b9b5bb4

- script: npm run compile

I suggest to either fix the esbuild script or to remove it, as it may cause a rabbit hole for others who run into this and wonder why CI is green.

Also, there should only be npm run compile or npm run build to avoid confusion.

The text was updated successfully, but these errors were encountered:

hediet changed the title ~~Fix or remove build script / npm run build~~ Remove either npm run compile or npm run build

hediet mentioned this issue

Separate vscode-dependent code from vscode-independent code #41

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment