Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal suggest: Only files/dirs starting with . show when typing ./ #222187

Closed
Tyriar opened this issue Jul 19, 2024 · 4 comments · Fixed by #222190
Closed

Terminal suggest: Only files/dirs starting with . show when typing ./ #222187

Tyriar opened this issue Jul 19, 2024 · 4 comments · Fixed by #222190
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux macos Issues with VS Code on MAC/OS X terminal-shell-pwsh An issue in the terminal specific to PowerShell terminal-suggest verified Verification succeeded
Milestone
July 2024

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 19, 2024

Repro:

  1. mac or linux/pwsh
  2. suggest enabled
  3. Type ./s, 🐛 should show ./scripts as an option
Screenshot 2024-07-19 at 7 03 49 AM
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X linux Issues with VS Code on Linux terminal-shell-pwsh An issue in the terminal specific to PowerShell terminal-suggest labels Jul 19, 2024
@Tyriar Tyriar added this to the July 2024 milestone Jul 19, 2024
@Tyriar Tyriar self-assigned this Jul 19, 2024
Tyriar added a commit that referenced this issue Jul 19, 2024
@Tyriar
Use terminal suggest trigger chars even when widget is visible
f76e7ab 
Fixes #222187
Tyriar added a commit that referenced this issue Jul 19, 2024
@Tyriar
Use terminal suggest trigger chars even when widget is visible
2c265b3 
Fixes #222187
@Tyriar Tyriar mentioned this issue Jul 19, 2024
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 19, 2024
@aiday-mar
Copy link
Contributor

I am still seeing this error:

Screen.Recording.2024-07-25.at.16.09.43.mov

curiously I did not see this error when I was testing the corresponding TPI on Tuesday. Not sure if maybe I didn't correctly configure my machine?

@aiday-mar aiday-mar added the verification-found Issue verification failed label Jul 25, 2024
@Tyriar
Copy link
Member Author

Tyriar commented Jul 25, 2024

Should be fixed by #223734

@Tyriar Tyriar reopened this Jul 25, 2024
@Tyriar Tyriar closed this as completed Jul 25, 2024
@Tyriar Tyriar removed the verification-found Issue verification failed label Jul 25, 2024
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Jul 25, 2024
@alexr00 alexr00 added the unreleased Patch has not yet been released in VS Code Insiders label Jul 25, 2024
@vscodenpa vscodenpa removed the unreleased Patch has not yet been released in VS Code Insiders label Jul 25, 2024
@vscodenpa
Copy link

Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting \closedWith someCommitSha, or directly add the insiders-released label if you know this has already been releaased

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 25, 2024
@Tyriar
Copy link
Member Author

Tyriar commented Jul 25, 2024

\closedWith f1cb13b

@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 26, 2024
@chrmarti chrmarti added the verified Verification succeeded label Jul 26, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux macos Issues with VS Code on MAC/OS X terminal-shell-pwsh An issue in the terminal specific to PowerShell terminal-suggest verified Verification succeeded
Projects
None yet
Milestone
July 2024
Development

Successfully merging a pull request may close this issue.

Use terminal suggest trigger chars even when widget is visible microsoft/vscode
5 participants
@Tyriar @chrmarti @alexr00 @aiday-mar @vscodenpa