Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal quick fix results in @vscode /explain in panel chat #223948

Closed
meganrogge opened this issue Jul 26, 2024 · 6 comments · Fixed by #224220
Closed

Terminal quick fix results in @vscode /explain in panel chat #223948

meganrogge opened this issue Jul 26, 2024 · 6 comments · Fixed by #224220
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal-chat Issues related to the terminal chat widget verified Verification succeeded
Milestone

Comments

@meganrogge
Copy link
Contributor

  1. run a command that yields an error in the terminal
  2. use the quick fix, Explain Using Copilot in the terminal, cmd+. -> `
  3. See @vscode /explain #terminalLastCommand in panel chat

Image

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-chat Issues related to the terminal chat widget labels Jul 26, 2024
@meganrogge meganrogge added this to the July 2024 milestone Jul 26, 2024
@bhavyaus
Copy link
Collaborator

bhavyaus commented Jul 26, 2024

I'm unable to repro this. However, I do see an issue with additional unnecessary contexts being invoked. See attached issue for more info.
Not a @vscode issue.

@bhavyaus bhavyaus assigned joyceerhl and unassigned bhavyaus Jul 26, 2024
@Tyriar Tyriar modified the milestones: July 2024, August 2024 Jul 29, 2024
@joyceerhl
Copy link
Contributor

I cannot reproduce this behavior when coming from the terminal quick fix @meganrogge:

Image

@joyceerhl
Copy link
Contributor

But the very first time I attempt submitting the query, I see that @terminal is not picked up by VS Code, cc @roblourens:

Image

@joyceerhl
Copy link
Contributor

Actually, I now repro @terminal not being picked up 100% of the time. We have two @terminals and we're picking the first one, then dropping it because it's not available in panel chat https://github.com/microsoft/vscode-copilot/blob/be960dbb84447b100951e51c1257e509eac8064a/package.json#L280-L314. #224220

@meganrogge
Copy link
Contributor Author

Today, I'm not seeing the copilot quick fix in the terminal at all 🤷‍♀

Image

@joyceerhl
Copy link
Contributor

Works for me on Windows with Powershell, latest Insiders + prerelease 🤷

@mjbvz mjbvz added verified Verification succeeded and removed verified Verification succeeded labels Aug 27, 2024
@meganrogge meganrogge added the verified Verification succeeded label Aug 28, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal-chat Issues related to the terminal chat widget verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants