Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codespaces: Terminal: MesloLGS NF's (Nerd Font patched) glyphs and symbols not rendered properly #231725

Closed
benz0li opened this issue Oct 19, 2024 · 8 comments
Assignees

Comments

@benz0li
Copy link

benz0li commented Oct 19, 2024

Does this issue occur when all extensions are disabled?: Not relevant

  • VS Code Version: 1.94.2, 384ff73, x64
  • OS Version: Debian 12 (bookworm)

Steps to Reproduce:

  1. Open https://github.com/b-data/data-science-devcontainers

  2. Codespaces > New with options...

    • Dev container configuration: Python base
  3. Install font Meslo LGS NF

    mkdir -p ${HOME}/.local/share/fonts/truetype/meslo
    curl -sSL https://github.com/romkatv/powerlevel10k-media/raw/master/MesloLGS%20NF%20Regular.ttf -o "${HOME}/.local/share/fonts/truetype/meslo/MesloLGS NF Regular.ttf"
    curl -sSL https://github.com/romkatv/powerlevel10k-media/raw/master/MesloLGS%20NF%20Bold.ttf -o "${HOME}/.local/share/fonts/truetype/meslo/MesloLGS NF Bold.ttf"
    curl -sSL https://github.com/romkatv/powerlevel10k-media/raw/master/MesloLGS%20NF%20Italic.ttf -o "${HOME}/.local/share/fonts/truetype/meslo/MesloLGS NF Italic.ttf"
    curl -sSL https://github.com/romkatv/powerlevel10k-media/raw/master/MesloLGS%20NF%20Bold%20Italic.ttf -o "${HOME}/.local/share/fonts/truetype/meslo/MesloLGS NF Bold Italic.ttf"
    fc-cache -fv
  4. Install Zsh theme Powerlevel10k

    git clone --depth=1 https://github.com/romkatv/powerlevel10k.git ${HOME}/.oh-my-zsh/custom/themes/powerlevel10k
  5. Change Zsh theme to Powerlevel10k

    sed -i 's/ZSH_THEME="devcontainers"/ZSH_THEME="powerlevel10k\/powerlevel10k"/g' ${HOME}/.zshrc
  6. Change Settings (User) > Features > Terminal > Integrated: Font Family: MesloLGS NF

  7. Open a new Terminal


Safari v18.0.1 (20619.1.26.31.7); Terminal › Integrated: Gpu Acceleration: auto

Does this look like a diamond (rotated square)? Yes

Image

Does this look like a lock? No

Image

Cross reference:

@benz0li
Copy link
Author

benz0li commented Oct 19, 2024

Safari v18.0.1 (20619.1.26.31.7); Terminal › Integrated: Gpu Acceleration: off

Does this look like a diamond (rotated square)? No

Image

@benz0li
Copy link
Author

benz0li commented Oct 19, 2024

Firefox 131.0.3; Terminal › Integrated: Gpu Acceleration: auto

Does this look like a diamond (rotated square)? Yes

Image

Does this look like a lock? No

Image

@benz0li
Copy link
Author

benz0li commented Oct 19, 2024

Firefox 131.0.3; Terminal › Integrated: Gpu Acceleration: off

Does this look like a diamond (rotated square)? No

Image

Ping @Tyriar

@benz0li
Copy link
Author

benz0li commented Oct 19, 2024

Interestingly, Firefox displays the Terminal with MesloLGS NF correctly at https://coder.jupyter.b-data.ch (code-server 4.94.2-rc.1 – aka Code 1.94.2).

@benz0li
Copy link
Author

benz0li commented Oct 19, 2024

The Terminal with MesloLGS NF worked fine for both Safari and Firefox up to code-server 4.93.1 – aka Code 1.93.1.

This version is currently deployed at https://demo.jupyter.b-data.ch.

@benz0li benz0li changed the title Codespaces: Terminal: MesloLGS NF (Nerd Font patched) does not properly display glyphs and symbols Codespaces: Terminal: MesloLGS NF (Nerd Font patched) does not render glyphs and symbols properly Oct 19, 2024
@benz0li benz0li changed the title Codespaces: Terminal: MesloLGS NF (Nerd Font patched) does not render glyphs and symbols properly Codespaces: Terminal: MesloLGS NF's (Nerd Font patched) glyphs and symbols not rendered properly Oct 19, 2024
@meganrogge meganrogge assigned Tyriar and unassigned meganrogge Oct 21, 2024
@Sovanda-Mith
Copy link

Version: 1.95.0
Os: Linux x64 6.8.0-47-generic snap

The issue still persists, my integrated terminal that uses the font family MesloLGS NF cannot rendered glyphs and symbols properly, what could be causing this problem and will there be a fix for this soon?

@benz0li
Copy link
Author

benz0li commented Nov 5, 2024

The problem is resolved for code-server v4.95.1-rc.2 – aka Code 1.95.1.

The problem still persists on Codespaces.

No problem with VS Code.

@benz0li
Copy link
Author

benz0li commented Nov 5, 2024

As I need to patch code-server to make this1 work, I do not think this works with Codespaces as is.

Footnotes

  1. Using a patched Nerd Font as Terminal Font Family.

@benz0li benz0li closed this as completed Nov 5, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants