Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration mechanism for versioned headers (hidspicx, spb, ufx, etc) #299

Open
leon-xd opened this issue Feb 20, 2025 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@leon-xd
Copy link
Contributor

leon-xd commented Feb 20, 2025

          General question - have we considered pulling out constants to a separate file? There's a lot of raw str slices around the configuration setup and I usually prefer to remove magic strings. After doing some research, there's not any clippy lints I could find that enforces this so not sure if this is achievable.

Originally posted by @leon-xd in #296 (comment)

@leon-xd
Copy link
Contributor Author

leon-xd commented Feb 20, 2025

Entire conversation in #296 is relevant

@wmmc88 wmmc88 added the enhancement New feature or request label Feb 20, 2025
@wmmc88 wmmc88 changed the title Pull out version magic strings into configurable setting in wdk-build Add configuration mechanism for versioned headers (hidspicx, spb, ufx, etc) Feb 20, 2025
@wmmc88
Copy link
Collaborator

wmmc88 commented Feb 20, 2025

I've changed the issue title from "Pull out version magic strings into configurable setting in wdk-build". Removing the magic strrings is more of a side-effect of implementing a configuration setting for all the different versioned headers in the WDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants