Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing jsons in POST/PATCH requests is not administrator friendly #2943

Open
nilakhan opened this issue Sep 5, 2024 · 1 comment
Open
Labels
type:feature New experience request

Comments

@nilakhan
Copy link

nilakhan commented Sep 5, 2024

Is your feature request related to a problem? Please describe the problem.

We have a set of cloud printing APIs exposed in Microsoft Graph.

Currently Graph generated powershell requires users to provide inputs for POST/PATCH requests as json, which is developer friendly but not admin friendly.
e.g. following is the comparison of Universal Print operations using custom Universal Print powershell module and Graph generated powershell module for sharing printer.

Universal Print powershell module:
New-UPPrinterShare -PrinterId "cdd44642-8fc3-4f55-bce2-d6d8069b40f2" -ShareName "First Floor Printer"

Graph generated powershell module:
$params = @{ DisplayName = "ShareName" AllowAllUsers = $false [email protected] = https://graph.microsoft.com/v1.0/print/printers/{printerId} }
New-MgPrintShare -BodyParameter $params

Hence, requesting Graph powershell team to address this concern.
This is blocking our team from deprecating Universal Print powershell module in favor of Graph generated powershell module.

Describe the solution you'd like.

Admins can provide required info as named parameters instead of jsons. e.g. consider Universal Print custom powershell module command for sharing printer:

New-UPPrinterShare -PrinterId "cdd44642-8fc3-4f55-bce2-d6d8069b40f2" -ShareName "First Floor Printer"

Additional context?

No response

@nilakhan nilakhan added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request labels Sep 5, 2024
@timayabi2020
Copy link
Contributor

@nilakhan thank you for proposing this feature of flattening the Json body into request parameters. We will look into it and hopefully come up with a solution that is friendly to the user as you have stated.
@CarolKigoonya

@timayabi2020 timayabi2020 removed the status:waiting-for-triage An issue that is yet to be reviewed or assigned label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New experience request
Projects
None yet
Development

No branches or pull requests

2 participants