Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading double pages #241

Closed
GenoXu opened this issue Aug 16, 2023 · 14 comments
Closed

Reading double pages #241

GenoXu opened this issue Aug 16, 2023 · 14 comments
Labels
enhancement New feature or request

Comments

@GenoXu
Copy link

GenoXu commented Aug 16, 2023

Some manga pages are double width.
To be able to read such pages, there is an option in CDisplayEx to zoom them into 150%, 200% or even 400% the original size using shortcuts (I use ctrl+Backspace to zoom 150% & Ctrl+Enter to go back to 100%)

image

@GenoXu GenoXu added the enhancement New feature or request label Aug 16, 2023
@mienaiyami
Copy link
Owner

Can't you do that already in Yomikiru? Or do you mean a keyboard shortcut for it?
You can use ctrl+scroll (resize) and shift+scroll (scroll horizontally)

@mienaiyami
Copy link
Owner

Now that I checked it again, there seems to be an issue with it. Some of the images are cut and do not scale beyond their original size.
I'll check.

@GenoXu
Copy link
Author

GenoXu commented Aug 16, 2023

Can't you do that already in Yomikiru? Or do you mean a keyboard shortcut for it? You can use ctrl+scroll (resize) and shift+scroll (scroll horizontally)

Yes, I am asking for shortcuts; one for zooming by 50% and one for zooming back into the original size (100%).

Now that I checked it again, there seems to be an issue with it. Some of the images are cut and do not scale beyond their original size. I'll check.

And yes, I also remarked this misbehavior (so I suggested the shortcut thing).

@GenoXu
Copy link
Author

GenoXu commented Aug 16, 2023

+ I noticed that I can't zoom double pages unless I change the reading mode into Free (even though I prefer reading while fitting the width)..

mienaiyami added a commit that referenced this issue Aug 26, 2023
@mienaiyami
Copy link
Owner

I only added current options temporarily, you can check in settings -> shortcutkeys.
The current shortcut system of app don't properly support keys like ctrl, shift or alt. I will make these shortcut customizable when i improve current system.

@GenoXu
Copy link
Author

GenoXu commented Aug 26, 2023

Fine, but it's jumping to the top every time I resize the page

@mienaiyami
Copy link
Owner

Wasn't in my tests. I'll check.

@mienaiyami
Copy link
Owner

I wasnt able to replicate this, but I tried something that might fix this, please report if it still does that.

@GenoXu
Copy link
Author

GenoXu commented Aug 28, 2023

Now that the jumping bug is fixed, I report two other things :)

  1. The zooming scale is too big compared to CDisplayX (150% in Yomikiru == 200% in CDisplayX)

  2. Double pages are still cut when scaled

@mienaiyami
Copy link
Owner

2. Double pages are still cut when scaled

I found the cause, will be fixing in next update.

Also, I doubt that 1. got fix, I couldnt test it. But fixing 2. will fix that automatically.

@GenoXu
Copy link
Author

GenoXu commented Aug 31, 2023

  1. is fixed indeed (for single pages only), but 2. persists (actually got worst)

@mienaiyami
Copy link
Owner

I couldnt test everything, so please report if you see any issue.

@mienaiyami mienaiyami reopened this Sep 10, 2023
@GenoXu
Copy link
Author

GenoXu commented Sep 12, 2023

Unfortunately, nothing is changed
You can test out the results on this chapter file (page 6 is the one shown above):
https://drive.google.com/uc?id=1iR8Q9ENPBIR-gIdjtEak3d8B7ToNTrLJ&export=download

@mienaiyami
Copy link
Owner

Some changed caused it to break for "Page per row - 1". Also it will only work with this enabled.
image

mienaiyami added a commit that referenced this issue Sep 18, 2023
@GenoXu GenoXu closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants