Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable reader side list option (Not hide, but do not execute) #269

Closed
xeolod opened this issue Sep 20, 2023 · 8 comments
Closed

Disable reader side list option (Not hide, but do not execute) #269

xeolod opened this issue Sep 20, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@xeolod
Copy link

xeolod commented Sep 20, 2023

Description of the new feature / enhancement

I request for the option to disable the reader sidelist for the entire app (Not hide, but do not execute). It might need app restart.

The reader side list is an amazing feature you thought for the app, but when there are many chapters for a comic or txt, single xhtml files, I found when enter / exit full screen it seems slow there, which is normal as there are 1000's of chapters.
Let's take martial peak as example, its comic version has 3500+ chapters, novel version is 4900+ chapters and both still ongoing. I think disabling (not executing) the side list via an option would help the app further improve both performance and memory usage.

This feature is a way to future-proof the app. This is my humble request.

Scenario when this would be used?

When a comic or novel has many chapters. If needed then user disable side list, if no need then user no need to disable side list.

Supporting information

I like that you had implemented single txt and xhtml files to be readbale for novels. A great feature no other app has implemented. I read martial peak novel both as epub and single xhtml files. The single xhtml files had improved performance of the app by a far greater margin than reading them as epub.

Sorry for the long words and bad english.

@xeolod xeolod added the enhancement New feature or request label Sep 20, 2023
@github-actions
Copy link

Thank you for your feedback and suggestions. Please note that the author might only respond on weekends, so we kindly ask for your patience and understanding.

@zeoint
Copy link

zeoint commented Sep 20, 2023

Cool idea.

@omodia
Copy link

omodia commented Sep 20, 2023

A great way to increase performance and decrease memory consumption of the app if user wishes to.
A future-proof idea indeed.

@mienaiyami
Copy link
Owner

but do not execute

Its not possible for epub, without it you wouldnt be able to change chapters or use internal link.
Im aware of the bad performance when changing chapters in epub reader as I too read a lot. I haven't been able to give it much time to improve it. It will require a lot of free time and clear mind to think for better and more performant solutions.

Also, while I recommend just moving read chapters in other folder if they are over 1000, I should have provided an option to not check for "valid folder" (with at least one image). Because now on initial reader open, it read all folders which might be resulting in lag for large chapter count. #272

@mienaiyami
Copy link
Owner

If you want a temporary solution you can use this in custom css file

.readerSideList:not(#dummy#dummy){
  display:none;
}

@xeolod
Copy link
Author

xeolod commented Sep 21, 2023

Its not possible for epub, without it you wouldnt be able to change chapters or use internal link.

Then, only do not execute reader side list for possible things like comics, txt, html.

I am not reading epubs in epub format. After u launch the new txt, xhtml system, Im using this systme. (Love the new system)
I find that history not recorded in the new system, I wanted to open a issue but find that its there already.

Im aware of the bad performance when changing chapters in epub reader as I too read a lot. I haven't been able to give it much time to improve it. It will require a lot of free time and clear mind to think for better and more performant solutions.

No prob, eventually. I wait.

@xeolod
Copy link
Author

xeolod commented Jan 23, 2024

I guess the hide list option (only UI) is sufficient as it did improve the performance by large comparred with before its not presant.
When its hidden, the performance is on par as for low chapter count.
That is y, i think the issue is pointless.

If anything, I request you to optimise the app and reader further, if ti could be done.

@xeolod xeolod closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2024
@mienaiyami
Copy link
Owner

I assumed it was also for manga reader. But that will continue at #272 I guess.

@mienaiyami mienaiyami moved this from Todo to Closed in yomikiru todo Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Closed
Development

No branches or pull requests

4 participants