Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader settings view #285

Open
mienaiyami opened this issue Sep 21, 2023 · 4 comments
Open

Reader settings view #285

mienaiyami opened this issue Sep 21, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@mienaiyami
Copy link
Owner

Type of reader (if reader related)

None

Description of the new feature / enhancement

Add option to hide reader setting toggle button and show it when the cursor is on the right side of the app, similar to side-list.

Scenario when this would be used?

No response

Supporting information

No response

@mienaiyami mienaiyami added the enhancement New feature or request label Sep 21, 2023
@mienaiyami mienaiyami moved this to Todo in yomikiru todo Sep 21, 2023
@github-actions
Copy link

Thank you for your feedback and suggestions. Please note that the author might only respond on weekends, so we kindly ask for your patience and understanding.

@omodia
Copy link

omodia commented Jan 23, 2024

similar to side-list.

You are not talking about changing the layout of reader settings and only the animation, right? Cause it looks great as it is.

A couple heads up,

  • The reader settings toggle button should only hide itself when the 'reader settings is closed' and "out of focus".
  • I stressed out of focus, because when an user opens and closes it using shortcut key, it would not go out of focus unless clicked elsewhere. So it should not hide itself when in-focus.

@mienaiyami
Copy link
Owner Author

I made it just as a reminder to change it soon in future. Because current one looks weird on that corner, with that rounded bottom-left corner.

@omodia
Copy link

omodia commented Jan 23, 2024

So the reader settings layout would not change, (by enabling the option in settings) the icon would disappear and reader settings would appear when the mouse cursor is hovered to right side of the screen. Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants