Merge pull request #63 from Kryvochyi/patch-2

Fix from getting "ValueError: '{IP}\n' does not appear to be an IPv4 or IPv6 address" error
mietzen · Sep 20, 2024 · e06c01f · e06c01f
2 parents 5e2dcc0 + ff78512
commit e06c01f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/porkbun_ddns/porkbun_ddns.py b/porkbun_ddns/porkbun_ddns.py
@@ -69,7 +69,7 @@ def get_public_ips(self) -> list:
                             with urllib.request.urlopen(url, timeout=10) as response:
                                 if response.getcode() == 200:
                                     public_ips.append(
-                                        response.read().decode("utf-8"))
+                                        response.read().decode("utf-8")).strip()
                                     break
                                 logger.warning(
                                     "Failed to retrieve IPv4 Address from %s! HTTP status code: %s", url, str(response.code()))
@@ -85,7 +85,7 @@ def get_public_ips(self) -> list:
                             with urllib.request.urlopen(url, timeout=10) as response:
                                 if response.getcode() == 200:
                                     public_ips.append(
-                                        response.read().decode("utf-8"))
+                                        response.read().decode("utf-8")).strip()
                                     break
                                 logger.warning(
                                     "Failed to retrieve IPv6 Address from %s! HTTP status code: %s", url, str(response.code()))