Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose download command/url to debug information perhaps for non-admin backup/restore ops #132

Open
shubham-pampattiwar opened this issue Dec 11, 2024 · 5 comments · May be fixed by #154
Open

Comments

@shubham-pampattiwar
Copy link
Member

This would help debug the B/R as the non-admin user will be able to fetch logs and describe the relevant Backup/Restore objects.

  • Velero CLI should work only on the non-admin user relevant objects
  • Check How to do this via DownloadBackupRequest, mimic Velero CLI behavior for commands like describe and logs using a new CRD
@mateusoliveira43
Copy link
Contributor

related to #7 ?

@mpryc
Copy link
Collaborator

mpryc commented Dec 11, 2024

related to #7 ?

I think so.

@kaovilai
Copy link
Member

kaovilai commented Jan 28, 2025

From Scrum we decided on providing NAC CLI/controller providing user an object store url / path / command that user can execute to retrieve relevant logs given they have bucket credentials to the path.

The con is non admin is assumed to have access to the entire bucket and there are no restrictions enforcable on retrievable paths from NAC side.

An alternative approach of using signed URL would enable possibility of NAC enforcing short lived signed URL so NAC CLI can download limited set of items users are granted access to (controlled by NAC) without requiring user to have bucket credentials.

@shubham-pampattiwar
Copy link
Member Author

Adding on to this:

  • The object storage URL would be part of the NAC object status (NAB/NAR).
  • The NAC object status would be patched with the URL at the end of Backup/Restore operation.
  • The motivation is to add more transparency for debugging via Logs, ResourceList and Errors.
  • Clear Documentation would be needed to specify the steps on how to extract the information from the object storage URL.
  • This work would act as a building block for a NAC CLI (if we want to pursue it in the future with expanded scope).

@shubham-pampattiwar shubham-pampattiwar moved this from Todo to In Progress in OADP Jan 28, 2025
@kaovilai
Copy link
Member

kaovilai commented Jan 28, 2025

This work would act as a building block for a NAC CLI (if we want to pursue it in the future with expanded scope).

So this issue should be renamed to expose download command/url to debug information perhaps and not exactly CLI building.

@shubham-pampattiwar shubham-pampattiwar changed the title Explore Velero CLI usage for non-admin users Expose download command/url to debug information perhaps for non-admin backup/restore ops Jan 28, 2025
@kaovilai kaovilai linked a pull request Jan 28, 2025 that will close this issue
@kaovilai kaovilai moved this from In Progress to Ready for Review in OADP Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Review
Development

Successfully merging a pull request may close this issue.

4 participants