-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove associated Non Admin Backups during Non Admin BSL removal #163
Remove associated Non Admin Backups during Non Admin BSL removal #163
Conversation
Calls delete on the Non Admin Backup objects referencing Non Admin BSL being removed. The Non Admin Backup controller will propagate the deletion further to remove Velero Backup objects associated with the Non Admin Backups. Signed-off-by: Michal Pryc <mpryc@redhat.com>
internal/controller/nonadminbackupstoragelocation_controller.go
Outdated
Show resolved
Hide resolved
Change the logic to not continue on the Non Admin Backup delete problems. Signed-off-by: Michal Pryc <mpryc@redhat.com>
Adjust of the design and diagram to ephasize Non Admin Backup deletion responsibility and it's influence on the Non Admin BSL finalizer removal. Signed-off-by: Michal Pryc <mpryc@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mateusoliveira43, mpryc, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Fixes #147
Calls delete on the Non Admin Backup objects referencing Non Admin BSL being removed. The Non Admin Backup controller will propagate the deletion further to remove Velero Backup objects associated with the Non Admin Backups.
Why the changes were made
Removal of the Non Admin Backup objects after NaBSL removal should happen from the non admin BSL reconcile.
If there are any left-overs GC should take action, so the GC controller should be independent of this logic.
The following delete call will trigger NAB reconcile to propagate this further and remove the Velero Backups
associated with the Non Admin Backup objects being removed.
How to test the changes made