Remove associated Non Admin Backups during Non Admin BSL removal #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls delete on the Non Admin Backup objects referencing Non Admin BSL being removed. The Non Admin Backup controller will propagate the deletion further to remove Velero Backup objects associated with the Non Admin Backups. Signed-off-by: Michal Pryc <mpryc@redhat.com>
Merged
internal/controller/nonadminbackupstoragelocation_controller.go
Outdated
Show resolved
Hide resolved
Change the logic to not continue on the Non Admin Backup delete problems. Signed-off-by: Michal Pryc <mpryc@redhat.com>
mateusoliveira43
previously approved these changes
Jan 31, 2025
This was referenced Jan 31, 2025
kaovilai
reviewed
Jan 31, 2025
Adjust of the design and diagram to ephasize Non Admin Backup deletion responsibility and it's influence on the Non Admin BSL finalizer removal. Signed-off-by: Michal Pryc <mpryc@redhat.com>
kaovilai
reviewed
Jan 31, 2025
mateusoliveira43
approved these changes
Feb 3, 2025
shubham-pampattiwar
approved these changes
Feb 3, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mateusoliveira43, mpryc, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
Calls delete on the Non Admin Backup objects referencing Non Admin BSL being removed. The Non Admin Backup controller will propagate the deletion further to remove Velero Backup objects associated with the Non Admin Backups.
Why the changes were made
Removal of the Non Admin Backup objects after NaBSL removal should happen from the non admin BSL reconcile.
If there are any left-overs GC should take action, so the GC controller should be independent of this logic.
The following delete call will trigger NAB reconcile to propagate this further and remove the Velero Backups
associated with the Non Admin Backup objects being removed.
How to test the changes made