New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for reconcile in tests should not be hardcoded #176

Closed

kaovilai opened this issue Feb 7, 2025 · 1 comment

Labels

CI

Member

kaovilai commented Feb 7, 2025 •

edited

Loading

This should be polling every x sec with a more relaxed max timeout like 30 seconds or 1 minute.

oadp-non-admin/internal/controller/nonadminbackup_controller_test.go

Line 1052 in 2a8aa27

time.Sleep(2 * time.Second)

It can be assumed that some env running our tests could fail this.

kaovilai added the CI label

Contributor

mateusoliveira43 commented Feb 7, 2025

duplication of #93

mateusoliveira43 closed this as completed

kaovilai closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment