Use docker-distribution that fixes OADP-4817, OADP-1945, OADP-3143 #112
+146
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use version of docker-distribution that contains the fixes for the following bugs: - OADP-4817 Imagestream backups are partially failing when dpa is configured with caCert - OADP-1945 caCert support for imagestream backup - OADP-3143 image registry backup: S3 storage doesn't use proxy environment when skipVerify=true Updated github action to reflect go version used in go.mod Signed-off-by: Michal Pryc <[email protected]>
|
/ok-to-test |
kaovilai
reviewed
Jan 21, 2025
kaovilai
requested changes
Jan 21, 2025
As requested we should be using 1.21 as the go version. Signed-off-by: Michal Pryc <[email protected]>
Use go version 1.21 in the go-pr workflow. Signed-off-by: Michal Pryc <[email protected]>
Bumped go.mod to include new AWS regions. Signed-off-by: Michal Pryc <[email protected]>
kaovilai
reviewed
Jan 21, 2025
- In the go.mod - In both github actions Signed-off-by: Michal Pryc <[email protected]>
kaovilai
reviewed
Jan 22, 2025
Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
approved these changes
Jan 22, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kaovilai, mpryc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use version of docker-distribution that contains the fixes for the following bugs:
OADP-4817 Imagestream backups are partially failing when dpa is configured with caCert
OADP-1945 caCert support for imagestream backup
OADP-3143 image registry backup: S3 storage doesn't use proxy environment when skipVerify=true