Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onEachDirectory callbacks only top level directory #57

Open
hados99 opened this issue Dec 17, 2018 · 1 comment
Open

onEachDirectory callbacks only top level directory #57

hados99 opened this issue Dec 17, 2018 · 1 comment

Comments

@hados99
Copy link
Contributor

hados99 commented Dec 17, 2018

Hi, really thanks for good library.

When testing onEachDirectory callback, it only returns top level directory.
I tested on nodejs v10, directory-tree v2.2.0, installed via npm.

I think onEachDirectory callback parameter is missing when calling directoryTree recursively.

node-directory-tree/lib/directory-tree.js

Line 99 in 5f2db29

.map(child => directoryTree(PATH.join(path, child), options, onEachFile))

@mihneadb
Copy link
Owner

Hi, good find! Feel free to submit a PR :).

mmontag added a commit to mmontag/chip-player-js that referenced this issue Aug 7, 2023
@mmontag
Pin directory-tree at version 2.2.1
b5b2996 
Other versions (2.4.0?) can cause problems in build-catalog.js (directories.json generation) because there was a change in the callback argument to dirTree() function.

Related: mihneadb/node-directory-tree#57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mihneadb @hados99