Fixed crashed when no profile returned for player

mikechambers · Jan 26, 2024 · def08f3 · def08f3
1 parent abf6b13
commit def08f3
Show file tree

Hide file tree

Showing 14 changed files with 31 additions and 19 deletions.
diff --git a/RELEASE.md b/RELEASE.md
@@ -1,5 +1,9 @@
 # dcli Release Notes
 
+## v0.99.8 January 26, 2024
+
+-   Fixed crash when adding player with no player profiles.
+
 ## v0.99.7 January 26, 2024
 
 -   Added support for Iron Banner Fortress (iron_banner_fortress)

diff --git a/src/Cargo.lock b/src/Cargo.lock
diff --git a/src/dcli/Cargo.toml b/src/dcli/Cargo.toml
@@ -1,7 +1,7 @@
 [package]
 name = "dcli"
 #version
-version = "0.99.7"
+version = "0.99.8"
 authors = ["Mike Chambers <[email protected]>"]
 edition = "2018"
 description = "Library for the dcli collection of command line tools for Destiny 2."

diff --git a/src/dcli/src/apiinterface.rs b/src/dcli/src/apiinterface.rs
@@ -265,6 +265,10 @@ impl ApiInterface {
             //TODO: should we have an error here if no profiles are returned?
             //that should not happen
 
+            if linked_profiles.profiles.is_empty() {
+                return Err(Error::NoProfilesFound);
+            }
+
             let mut most_recent: &DestinyProfileUserInfoCard =
                 &linked_profiles.profiles[0];
 

diff --git a/src/dcli/src/error.rs b/src/dcli/src/error.rs
@@ -66,6 +66,7 @@ pub enum Error {
     ActivityNotFound,
     DateTimePeriodOrder,
     BungieNameNotFound,
+    NoProfilesFound,
     InvalidArgument { description: String },
 }
 
@@ -170,6 +171,9 @@ impl Display for Error {
             Error::BungieNameNotFound  => {
                 write!(f, "Bungie name not found.")
             },
+            Error::NoProfilesFound  => {
+                write!(f, "No player profiles found.")
+            },
         }
     }
 }

diff --git a/src/dclia/Cargo.toml b/src/dclia/Cargo.toml
@@ -1,7 +1,7 @@
 [package]
 name = "dclia"
 #version
-version = "0.99.7"
+version = "0.99.8"
 authors = ["Mike Chambers <[email protected]>"]
 description = "Command line tool for retrieving information on current activity for specified player character."
 homepage = "https://www.mikechambers.com"

diff --git a/src/dcliad/Cargo.toml b/src/dcliad/Cargo.toml
@@ -1,7 +1,7 @@
 [package]
 name = "dcliad"
 #version
-version = "0.99.7"
+version = "0.99.8"
 authors = ["Mike Chambers <[email protected]>"]
 edition = "2018"
 description = "Command line tool for viewing Destiny 2 activity details."

diff --git a/src/dcliah/Cargo.toml b/src/dcliah/Cargo.toml
@@ -1,7 +1,7 @@
 [package]
 name = "dcliah"
 #version
-version = "0.99.7"
+version = "0.99.8"
 authors = ["Mike Chambers <[email protected]>"]
 edition = "2018"
 description = "Command line tool for viewing Destiny 2 activity history."

diff --git a/src/dclif/Cargo.toml b/src/dclif/Cargo.toml
@@ -1,7 +1,7 @@
 [package]
 name = "dclif"
 #version
-version = "0.99.7"
+version = "0.99.8"
 authors = ["Mike Chambers <[email protected]>"]
 edition = "2018"
 description = "Command line tool for querying specific Destiny 2 pvp stats."

diff --git a/src/dclim/Cargo.toml b/src/dclim/Cargo.toml
@@ -1,7 +1,7 @@
 [package]
 name = "dclim"
 #version
-version = "0.99.7"
+version = "0.99.8"
 authors = ["Mike Chambers <[email protected]>"]
 edition = "2018"
 description = "Command line tool for managing and syncing the remote Destiny 2 API manifest database."

diff --git a/src/dclistat/Cargo.toml b/src/dclistat/Cargo.toml
@@ -1,7 +1,7 @@
 [package]
 name = "dclistat"
 #version
-version = "0.99.7"
+version = "0.99.8"
 authors = ["Mike Chambers <[email protected]>"]
 edition = "2018"
 description = "Command line tool for querying specific Destiny 2 pvp stats."

diff --git a/src/dclisync/Cargo.toml b/src/dclisync/Cargo.toml
@@ -1,7 +1,7 @@
 [package]
 name = "dclisync"
 #version
-version = "0.99.7"
+version = "0.99.8"
 authors = ["Mike Chambers <[email protected]>"]
 edition = "2018"
 description = "Command line tool for downloading and syncing Destiny 2 Crucible activity history."

diff --git a/src/dclitime/Cargo.toml b/src/dclitime/Cargo.toml
@@ -1,7 +1,7 @@
 [package]
 name = "dclitime"
 #version
-version = "0.99.7"
+version = "0.99.8"
 authors = ["Mike Chambers <[email protected]>"]
 edition = "2018"
 description = "Command line tool for retrieving Destiny 2 related date / time stamps"

diff --git a/src/tell/Cargo.toml b/src/tell/Cargo.toml
@@ -1,7 +1,7 @@
 [package]
 name = "tell"
 #version
-version = "0.99.7"
+version = "0.99.8"
 authors = ["Mike Chambers <[email protected]>"]
 edition = "2018"
 description = "Simple library for handling different levels of user output for command line apps."