Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw ROC Curves #4

Closed
linan7788626 opened this issue Jun 10, 2019 · 6 comments
Closed

Draw ROC Curves #4

linan7788626 opened this issue Jun 10, 2019 · 6 comments

Comments

@linan7788626
Copy link
Collaborator

linan7788626 commented Jun 10, 2019

Need more discussion about this script

https://github.com/milesxu/SSLDeepLens/blob/master/generate_roc_curve.py

@linan7788626 linan7788626 changed the title Draw ROCs Draw ROC Curves Jun 10, 2019
@linan7788626
Copy link
Collaborator Author

@milesxu I think we should make a plot the ROC curve with xrange(0,1) and yrange(0.1) to take a look at the shape of the curve first. Can you please draw the plot and post here? Thanks

@milesxu
Copy link
Owner

milesxu commented Jun 22, 2019

roc_curve
I have changed plt.xlim and ylim. The result is above.

@linan7788626
Copy link
Collaborator Author

Thanks for the update, it looks reasonable to me, let see whether there would be any improvement with the new approach of preprocessing. BTW, I attached the table of the results of the entries in the lens finding challenge, if you could please list the Area under the ROC, then we can evaluate our outcome more straightforwardly. In this case, we should compare our results to that of ground-based telescopes in the table.

Screenshot 2019-06-22 at 16 00 17

@linan7788626
Copy link
Collaborator Author

Hello @milesxu, just a gentle inquiry, is there any progress about this? BTW, can you please also take a look at the pull request I submitted days ago #5 , thanks a lot.

All the best,
Nan

@milesxu
Copy link
Owner

milesxu commented Sep 9, 2019

roc_curve_2019-09-09-14-46-53
I have changed the code to use sklearn to compute ROC arrays and then plot them.
Now I am trying to figure out how to compute TPR0 and TPR10.

@linan7788626
Copy link
Collaborator Author

@milesxu I am closing this issue because this one is updated to #6 now. Please feel free to reopen it if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants