Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass height to abci query #1

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix: pass height to abci query #1

merged 1 commit into from
Mar 28, 2024

Conversation

hallazzang
Copy link

Description

Extract x-cosmos-block-height from the outgoing Context and pass it to abci_query query so that we can do historical queries.

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Re-reviewed Files changed in the Github PR explorer.

@hallazzang hallazzang self-assigned this Mar 28, 2024
@hallazzang hallazzang marked this pull request as ready for review March 28, 2024 11:22
@RiccardoM RiccardoM merged commit fdb52a8 into dymension Mar 28, 2024
2 of 3 checks passed
RiccardoM pushed a commit that referenced this pull request Apr 8, 2024
@hallazzang @RiccardoM
fix: pass height to abci query (#1)
84145ec
@RiccardoM RiccardoM deleted the hallazzang/fix-rpc-client branch May 28, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoM RiccardoM RiccardoM approved these changes

Assignees

@hallazzang hallazzang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hallazzang @RiccardoM