Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactory: improvments of typo and some hotfix #249

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

matrixji
Copy link
Collaborator

No description provided.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matrixji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0141b50) 97.33% compared to head (9daf8fc) 97.33%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files          34       34           
  Lines        2624     2625    +1     
=======================================
+ Hits         2554     2555    +1     
  Misses         70       70           
Files Coverage Δ
src/impl/MilvusClientImpl.cpp 94.72% <100.00%> (+<0.01%) ⬆️
src/impl/MilvusClientImpl.h 100.00% <100.00%> (ø)
src/impl/MilvusConnection.cpp 99.24% <100.00%> (ø)
src/impl/MilvusConnection.h 100.00% <100.00%> (ø)
src/impl/Status.cpp 100.00% <ø> (ø)
src/impl/TypeUtils.cpp 98.41% <100.00%> (ø)
src/impl/types/CalcDistanceArguments.cpp 100.00% <ø> (ø)
src/impl/types/CollectionStat.cpp 100.00% <100.00%> (ø)
src/impl/types/CompactionState.cpp 100.00% <ø> (ø)
src/impl/types/ConnectParam.cpp 85.24% <ø> (ø)
... and 7 more

@matrixji matrixji added the lgtm label Jan 14, 2024
@sre-ci-robot sre-ci-robot merged commit 0127694 into milvus-io:master Jan 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants