Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] dump pprof info if component stop progress timeout #39760

Open
wants to merge 2 commits into
base: 2.5
Choose a base branch
from

Conversation

weiliu1031
Copy link
Contributor

issue: #39735
pr: #39726

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Feb 10, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 10, 2025
@weiliu1031 weiliu1031 changed the title enhance: dump pprof info if component stop progress timeout enhance: [2.5] dump pprof info if component stop progress timeout Feb 10, 2025
Copy link
Contributor

mergify bot commented Feb 10, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 10, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567 yanliang567 added this to the 2.5.5 milestone Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (87b39c2) to head (f4e39fa).
Report is 4 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39760       +/-   ##
===========================================
+ Coverage   69.46%   81.07%   +11.61%     
===========================================
  Files         300     1415     +1115     
  Lines       26798   198909   +172111     
===========================================
+ Hits        18616   161273   +142657     
- Misses       8182    32002    +23820     
- Partials        0     5634     +5634     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.46% <ø> (ø)
Go 83.05% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/distributed/utils/util.go 80.00% <100.00%> (ø)
pkg/util/paramtable/grpc_param.go 85.85% <100.00%> (ø)
pkg/util/paramtable/service_param.go 99.18% <100.00%> (ø)

... and 1112 files with indirect coverage changes

@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 11, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 11, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: Wei Liu <[email protected]>
Copy link
Contributor

mergify bot commented Feb 11, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 11, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants