fix: cannot pass consistency level for delete #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
XuanYang-cn
added a commit
to XuanYang-cn/pymilvus
that referenced
this pull request
Nov 15, 2024
See also: milvus-io#2327 pr: milvus-io#2350 Signed-off-by: yangxuan <[email protected]>
XuanYang-cn
force-pushed
the
fix-consis
branch
from
c1e15a5
to
fba8794
Compare
XuanYang-cn
added a commit
to XuanYang-cn/pymilvus
that referenced
this pull request
Nov 15, 2024
Also optinal variables default value should always be None. And empty str is always invalid variable See also: milvus-io#2327 pr: milvus-io#2350 Signed-off-by: yangxuan <[email protected]>
czs007
reviewed
Nov 18, 2024
Also optinal variables default value should always be None. And empty str is always invalid variable See also: milvus-io#2327 Signed-off-by: yangxuan <[email protected]>
Signed-off-by: yangxuan <[email protected]>
XuanYang-cn
force-pushed
the
fix-consis
branch
from
4fd2e0a
to
5aa7dc9
Compare
Signed-off-by: yangxuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also optinal variables default value should always be None.
And empty str is always invalid variable
See also: #2327