New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit `add_shared_param!`: data type and removal of `add_model_param!` #831

Open

lrennels opened this issue Jun 2, 2021 · 0 comments

Assignees

Labels

needs-design-discussion simplification

Milestone

Collaborator

lrennels commented Jun 2, 2021 •

edited

Loading

revisit the corner cases of when you parameterize a Parameter (ie. p = Parameter{Int64}()) and how that works with connecting to a shared model parameter
treatment of DataTypes in add_shared_param! ... what are the requirements?
can we get to a place where we completely phase out add_model_param methods with values arg?

The text was updated successfully, but these errors were encountered:

lrennels self-assigned this

lrennels added needs-design-discussion simplification labels

lrennels changed the title ~~Revisit Parameter DataTypes etc.~~ Revisit add_shared_param!: data type and removal of add_model_param!

lrennels added this to the v1.4.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment