Improvements and bugfixes #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update (2019-05-11) :
|
added 9 commits
June 27, 2019 13:20
- Add better tests (easier to read) ; - Classify char code 160 as whitespace ; - Split test cleaning and sentence parsing. It is now working quite well to format texts extracted from PDF files with Apache Tika. - Closes Issue 104 : TokenInstanceIterator does not iterate on more than one Instance. - Closes Issue 126 : printDocumentTopics() throws an IndexOutOfBoundsException if the number of topics is not the same as the number of documents.
- Add better tests (easier to read) ; - Classify char code 160 as whitespace ; - Split test cleaning and sentence parsing. It is now working quite well to format texts extracted from PDF files with Apache Tika. - Closes Issue 104 : TokenInstanceIterator does not iterate on more than one Instance. - Closes Issue 126 : printDocumentTopics() throws an IndexOutOfBoundsException if the number of topics is not the same as the number of documents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements on StringIterator :
Closes Issue 104 :
TokenInstanceIteratordoes not iterate on more than oneInstance.Closes Issue 126 :
printDocumentTopics()throws anIndexOutOfBoundsExceptionif the number of topics is not the same as the number of documents.Be aware that due to compilation issues on Windows 10 I had to remove the symlink from
lib/errorprone.jarin thebuild.xmlfile (commit ec265c3). Tell me if I need to rollback it for the pull-request.