Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow semantic versioning #6

Open
MatthewCaseres opened this issue Nov 22, 2022 · 2 comments
Open

follow semantic versioning #6

MatthewCaseres opened this issue Nov 22, 2022 · 2 comments

Comments

@MatthewCaseres
Copy link

MatthewCaseres commented Nov 22, 2022

"Once a versioned package has been released, the contents of that version MUST NOT be modified. Any modifications MUST be released as a new version." https://semver.org/

I don't know which version of 0.0.1 is compatible with the dependencies here - mimoralea/gdrl#29, maybe they all are up until the change from 0.0.1 to 0.0.2, unsure.

@mimoralea
Copy link
Owner

I think you're referring to me updating the package at some point but not moving up the version, right? That was my mistake here. Open to suggestions on how to do this right--I'm not a pro at CI/CD test or even software engineering. Any help is appreciated.

@MatthewCaseres
Copy link
Author

MatthewCaseres commented Nov 23, 2022

In the right sidebar of the repo you will see a section that says "releases" and this release is something you would manually create. When you create the release we can run a workflow like this and it will

  • bump the version to have the tag specified in the release ("0.3.0" for the next release of this package)
  • publish the package to PyPI

Having formal releases in this way would resolve this issue I think. I will try to get a PR done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants