From 7e3eeaf4edfa447e5b32fd384c26b075fed18504 Mon Sep 17 00:00:00 2001
From: Eleftheria Stein-Kousathana <eleftheria@stacklok.com>
Date: Mon, 18 Nov 2024 17:38:34 +0100
Subject: [PATCH] Validate rule type alert during creation / update

---
 pkg/api/protobuf/go/minder/v1/validators.go   | 33 ++++++++++++
 .../protobuf/go/minder/v1/validators_test.go  | 50 +++++++++++++++++++
 2 files changed, 83 insertions(+)

diff --git a/pkg/api/protobuf/go/minder/v1/validators.go b/pkg/api/protobuf/go/minder/v1/validators.go
index b7e6b2ddf5..8267b14562 100644
--- a/pkg/api/protobuf/go/minder/v1/validators.go
+++ b/pkg/api/protobuf/go/minder/v1/validators.go
@@ -177,6 +177,13 @@ func (def *RuleType_Definition) Validate() error {
 		return err
 	}
 
+	// Alert is not required and can be nil
+	if def.Alert != nil {
+		if err := def.Alert.Validate(); err != nil {
+			return err
+		}
+	}
+
 	return def.Eval.Validate()
 }
 
@@ -286,6 +293,32 @@ func (ing *RuleType_Definition_Ingest) Validate() error {
 	return nil
 }
 
+// Validate validates a rule type definition alert
+func (alert *RuleType_Definition_Alert) Validate() error {
+	if alert == nil {
+		return nil
+	}
+
+	// Not using import to avoid circular dependency
+	if alert.Type == "security_advisory" {
+		if err := alert.GetSecurityAdvisory().Validate(); err != nil {
+			return err
+		}
+	} else {
+		return fmt.Errorf("%w: alert type cannot be empty", ErrInvalidRuleTypeDefinition)
+	}
+	return nil
+}
+
+// Validate validates a rule type alert security advisory
+func (sa *RuleType_Definition_Alert_AlertTypeSA) Validate() error {
+	if sa == nil {
+		return fmt.Errorf("%w: security advisory is nil", ErrInvalidRuleTypeDefinition)
+	}
+
+	return nil
+}
+
 // Validate validates a rule type definition ingest diff
 func (diffing *DiffType) Validate() error {
 	if diffing == nil {
diff --git a/pkg/api/protobuf/go/minder/v1/validators_test.go b/pkg/api/protobuf/go/minder/v1/validators_test.go
index d04c15e9e8..1982d16919 100644
--- a/pkg/api/protobuf/go/minder/v1/validators_test.go
+++ b/pkg/api/protobuf/go/minder/v1/validators_test.go
@@ -194,3 +194,53 @@ func TestRuleType_Definition_Eval_Rego_Validate(t *testing.T) {
 		})
 	}
 }
+
+func TestRuleType_Definition_Alert_Validate(t *testing.T) {
+	t.Parallel()
+	tests := []struct {
+		name    string
+		alert   *RuleType_Definition_Alert
+		wantErr bool
+	}{
+		{
+			name: "valid alert definition",
+			alert: &RuleType_Definition_Alert{
+				Type:             "security_advisory",
+				SecurityAdvisory: &RuleType_Definition_Alert_AlertTypeSA{},
+			},
+			wantErr: false,
+		},
+		{
+			name:    "nil alert is valid",
+			alert:   nil,
+			wantErr: false,
+		},
+		{
+			name: "empty alert type",
+			alert: &RuleType_Definition_Alert{
+				Type: "",
+			},
+			wantErr: true,
+		},
+		{
+			name: "invalid security advisory",
+			alert: &RuleType_Definition_Alert{
+				Type:             "security_advisory",
+				SecurityAdvisory: nil,
+			},
+			wantErr: true,
+		},
+	}
+
+	for _, tt := range tests {
+		tt := tt
+		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
+			err := tt.alert.Validate()
+			if (err != nil) != tt.wantErr {
+				t.Errorf("Validate() error = %v, wantErr %v", err, tt.wantErr)
+			}
+		})
+	}
+}