Have run-docker-teardown respect services variable (#4884)

Have run-docker-teardown respect services
mindersec · Nov 5, 2024 · 7e6460a · 7e6460a
1 parent 9a6ff91
commit 7e6460a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.mk/develop.mk b/.mk/develop.mk
@@ -21,8 +21,8 @@ run-server: ## run the app
 .PHONY: run-docker-teardown
 run-docker-teardown: ## teardown the docker compose environment
 ifeq ($(RUN_DOCKER_NO_TEARDOWN),false)
-	@echo "Running docker compose down"
-	@$(COMPOSE) down
+	@echo "Running docker compose down $(services)..."
+	@$(COMPOSE) down $(services)
 else
 	@echo "Skipping docker compose down"
 endif
@@ -42,7 +42,7 @@ run-docker: run-docker-teardown ## run the app under docker compose
 .PHONY: stop-docker
 stop-docker: ## stop the app under docker compose
 	@echo "Running docker compose down $(services)..."
-	@$(COMPOSE) down
+	@$(COMPOSE) down $(services)
 
 .PHONY: pre-commit
 pre-commit:	## run pre-commit hooks

diff --git a/docs/docs/developer_guide/get-hacking.md b/docs/docs/developer_guide/get-hacking.md
@@ -10,6 +10,11 @@ Follow the steps in the [Installing a Development version](./../run_minder_serve
 
 The application will be available on `https://localhost:8080` and gRPC on `https://localhost:8090`.
 
+When iterating, it can be helpful to only rebuild and reload the `minder` container.  You can do this with:
+```bash
+make run-docker services=minder
+```
+
 ## Run the tests
 ```bash
 make test