Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw for unexpected properties #40

Open
mindplay-dk opened this issue Aug 30, 2017 · 1 comment
Open

Throw for unexpected properties #40

mindplay-dk opened this issue Aug 30, 2017 · 1 comment
Milestone
1.0

Comments

@mindplay-dk
Copy link
Owner

Currently, UpdateQuery::assign() will silently ignore unexpected properties.

This leads to silent bugs.

We should throw an exception for unexpected properties.
@mindplay-dk mindplay-dk added this to the 1.0 milestone Aug 30, 2017
@mindplay-dk
Copy link
Owner Author

This currently affects InsertQuery::add() as well - though I'm wondering if changing that is potentially a breaking change? e.g. for sloppy code that relies on things like get_object_vars() to quickly serialize model-properties?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@mindplay-dk