Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up redundant line-builders #48

Open
mindplay-dk opened this issue Mar 26, 2019 · 0 comments
Open

Clean up redundant line-builders #48

mindplay-dk opened this issue Mar 26, 2019 · 0 comments
Labels

Comments

@mindplay-dk
Copy link
Owner

Many of the query-builders duplicate portions of building certain lines of various queries.

For example, the Conditions trait only builds the actual conditions, not the WHERE clause itself - every query-builder duplicates that part.

Change the internal API so the Conditions, Limit, Order, Range, Returning build complete lines. (or empty strings when they're empty.)

For consistency, follow the same pattern for query-specific lines internally in all query-builders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant