Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No refmap loaded #40

Open
halotroop2288 opened this issue Aug 30, 2021 · 6 comments
Open

No refmap loaded #40

halotroop2288 opened this issue Aug 30, 2021 · 6 comments
Labels
bug Something isn't working help wanted Extra attention is needed Investigation Required

Comments

@halotroop2288
Copy link

Compatibility is broken with other mappings because mixins fail due to using mapped injection points.
Fix this by including a refmap.

@valoeghese
Copy link
Member

wait it doesn't have a generated refmap? 😳

Probably a problem with mixin compiling

@valoeghese valoeghese added the bug Something isn't working label Oct 29, 2021
@valoeghese
Copy link
Member

Calimamsy seems to indicate the problem was probably not on our end? CLAPI has a refmap, so "including a refmap" can't be the problem.

@valoeghese valoeghese added invalid This doesn't seem right wontfix This will not be worked on labels Oct 29, 2021
@valoeghese
Copy link
Member

valoeghese commented Oct 29, 2021

I'll close this for now as we do have refmaps, so your comment on how to fix is invalid. And your workspace was modified in other ways, so there is a possibility it could have been that.

If you have reason to believe the problem IS on our end and that the normal Cursed Legacy workspace does not work with other mapping sets, please feel free to reopen the issue with attached evidence and please give an indication of which mixins are not remapping on compile correctly.

@halotroop2288
Copy link
Author

Calimamsy seems to indicate the problem was probably not on our end?

What does Calimamsy know? How to start a feud over nothing is all I've seen. I seeked their guidance on making these APIs more compatible with one another and they only responded with hostility.

CLAPI has a refmap, so "including a refmap" can't be the problem.

I'd really like to see some evidence on that. My logs say otherwise.

And your workspace was modified in other ways, so there is a possibility it could have been that.

Yeah, this is programming. We all modify our workspaces to suit our needs. You're gonna have to be more specific oh what you think I modified that would cause this.

which mixins are not remapping on compile correctly

These Mixins were not remapping via Loom on import as a dependency. This caused startup to fail while applying them. You can try this yourself by making a new mod and applying BTU's mappings, or even BIN-Mappings.

reopen the issue with attached evidence

There is no chance of me returning, unless the whole of the pre-1.3 Fabric modding scene sees major changes. Using this toolchain is like pulling teeth.

I'm looking at Chocohead for maintaining an outdated version of Loom with unnecessary unique features as our only way of creating Fabric mods for pre-1.3 versions, and ModificationStation for making an API that's incompatible with the more official one, and letting it become widely adopted.

Yes. I realize this is nearly impossible to fix this now. And that's exactly why I won't be returning. It is a toxic environment which I no longer have any problem responding to with my own toxicity.

@valoeghese
Copy link
Member

valoeghese commented Oct 29, 2021

I'd really like to see some evidence on that. My logs say otherwise.

I did look into the problem you presented, and investigated the cursed legacy api 1.1.0 jar file. Here are some examples of the refmaps.

image
image

I would prefer to not turn this into a toxic argument, as that does no good to either side. I shall reopen this issue, as it is a pertinent issue that, as you have mentioned, was likely prematurely closed. I shall test at a later date. The issue at hand is likely not the absence of a refmap, but a problem generating the refmap. Loom has had such problems in other projects in the past and even now, for example, Lint currently doesn't work in prod due to a refmap not being generated properly.

@valoeghese valoeghese reopened this Oct 29, 2021
@valoeghese valoeghese added help wanted Extra attention is needed Investigation Required and removed wontfix This will not be worked on invalid This doesn't seem right labels Oct 29, 2021
@valoeghese
Copy link
Member

Speaking of making the APIs more compatible, I already plan on working on that in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed Investigation Required
Projects
None yet
Development

No branches or pull requests

2 participants