Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more diagnostic warnings #4

Open
MCMrARM opened this issue Dec 1, 2018 · 1 comment
Open

Add some more diagnostic warnings #4

MCMrARM opened this issue Dec 1, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@MCMrARM
Copy link
Member

MCMrARM commented Dec 1, 2018

We should show a warning when the launcher would use software rendering (llvmpipe). This could be achieved by parsing the output of mcpelauncher-client -v, which looks like the following:

mcpelauncher-client 145d215 / manifest b016744
CPU: GenuineIntel Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz
SSSE3 support: YES
GL Vendor: nouveau
GL Renderer: NV120
GL Version: OpenGL ES 3.2 Mesa 18.2.4

and checking whether the GL Version string contains llvmpipe or not. Except for the first line, the output will be expected to be in the form of Key: Value. User should be linked to a wiki page (that should be created) where he can find how to properly install the driver for their system.
Additionally, a warning should be shown when SSSE3 support is NO. User should also be linked to a wiki page explaining why this is a problem.

In both cases a [Do not show again] checkbox should exist.

@MCMrARM MCMrARM added enhancement New feature or request help wanted Extra attention is needed labels Dec 1, 2018
@MCMrARM MCMrARM removed the help wanted Extra attention is needed label Dec 18, 2018
@MCMrARM
Copy link
Member Author

MCMrARM commented Dec 18, 2018

This has been largely implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant