Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCD lines and character limits #66

Open
PeterNerlich opened this issue Dec 8, 2020 · 4 comments
Open

LCD lines and character limits #66

PeterNerlich opened this issue Dec 8, 2020 · 4 comments

Comments

@PeterNerlich
Copy link
Contributor

Currently the LCD screen has quite big borders and a very limited amount of text that can be displayed. I have come across intentions to connect multiple LCDs to one big display array. In that case, there is much less space to print characters than one would expect. Maybe it would be better to do this in a separate mod, probably there were some considerations why the limits were set as they are and I'd like to hear them and what your thoughts are about making more characters fit on screen.
I fixed the calculations in #64 enabling me to play around with this a bit:

Old screen with 5 lines, 12 chars each (fixed positioning as of #64):

screenshot_20201207_194317

Max character cramming (6 lines by decreasing line height by one, 14 chars each):

screenshot_20201207_194213

Inbetween with 6 lines, 13 chars each:

screenshot_20201207_195319

@SmallJoker
Copy link
Member

#64 merged

@PeterNerlich
Copy link
Contributor Author

I did not intend to address the same as #64, I wanted to start a conversation on whether to increase the number of characters displayed on the LCD screen. Only the first screenshot is what #64 looks like, and only changes the positioning for the current limits as well as making it properly generalized to enable changing those limits without it glitching out again. The subsequent screenshots are examples to demonstrate exactly that and give a basis to kickstart the conversation.

Thus, I kindly ask you to reopen the issue. And don't apologise, I firmly expect this to be an accidental thing because this looked the same and mentions #64. As does this comment now, thrice even... 😅

@SmallJoker SmallJoker reopened this Dec 10, 2020
@SmallJoker
Copy link
Member

Well, I'd say that using all available space is the desired behaviour - as long it's guaranteed that no letters overshoot (handled already).

@PeterNerlich
Copy link
Contributor Author

PeterNerlich commented Dec 10, 2020

Not necessarily with the line number though. While the individual lines are each centered, we do not vertically center by first seeing how many lines we end up with and then distributing the leftover space, so changing this would make many existing contraptions that just use a limited number of lines look ugly all of the sudden. I'm just speculating though, that's why I wanted to ask those who have observed this longer than me.
If making designs ugly is of no concern and having as much space available as possible is much desirable, I could make that PR right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants