Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fake player code with fakelib #10

Merged
merged 4 commits into from
May 30, 2024

Conversation

OgelGames
Copy link
Contributor

Replaces the fake player code with fakelib's fake player.

https://content.minetest.net/packages/OgelGames/fakelib/

@OgelGames OgelGames mentioned this pull request May 21, 2024
4 tasks
@SmallJoker
Copy link
Member

SmallJoker commented May 21, 2024

A few weeks ago I wanted to implement the fake player API in the engine using a detached RemotePlayer so that such implementations would no longer be necessary. Unfortunately that addition would require special handling in (my option too) many functions.

For the time being I suppose it's easiest to rely on a "proper" Lua implementation. The code looks good. I'll give it a try by the next opportunity.

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Would you please be so nice to mention this dependency in the README.md? It's the only hard dependency, so having it listed there would be very helpful if someone wanted to install it manually (e.g. server owners).

OgelGames added 2 commits May 23, 2024 14:37
so the real player doesn't feel the effects of placing dozens of torches
@SmallJoker
Copy link
Member

Thanks. Will merge in a few days unless there are objections.

@SmallJoker SmallJoker merged commit 3cb912d into minetest-mods:master May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants